Related Issues

Proposed Changes

1. Improve MineBlocksMustPost, a testing helper I first made to remove flakes from cc upgrade itest
2. Use in paych api test

Additional Info

@TheDivic brought my attention to flaky behavior in a few tests. Looking at the logs here I saw the same error message from the cc upgrade itest:

2022-02-13T16:16:46.332Z	WARN	vm	vm/runtime.go:350	Abortf: invalid deadline 0 at epoch 718, expected 1
2022-02-13T16:16:46.332Z	WARN	vm	vm/runtime.go:161	VM.Call failure in call from: f0102 to f01000: invalid deadline 0 at epoch 718, expected 1 (RetCode=16):   

I had previously debugged this and tracked it down to the behavior of post. The post scheduler returns no errors so post failures are totally left out of testing logic. However when mining blocks in integration tests post failures will take down the whole miner and fail the test.

The idea behind MineBlocksMustPost is to force block mining to wait on any expected post messages being included before moving past a deadline.

Checklist

Before you mark the PR ready for review, please make sure that:

• All commits have a clear commit message.
• The PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
  • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
• This PR has tests for new functionality or change in behaviour
• If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
• CI is green